Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pvr] Modify API calls for EPG Timeframe to support past (archive) days as well as future days #19035

Merged
merged 1 commit into from Jan 8, 2021
Merged

[pvr] Modify API calls for EPG Timeframe to support past (archive) days as well as future days #19035

merged 1 commit into from Jan 8, 2021

Conversation

phunkyfish
Copy link
Contributor

Description

Now that there is support for archive there needs to be a way for add-ons to be informed of the past number of days stored by kodi in the EPG.

Motivation and Context

No way for add-ons to preload the correct amount of past/archive data.

How Has This Been Tested?

MacOSX

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@phunkyfish phunkyfish added Type: Feature non-breaking change which adds functionality Component: PVR Component: Binary add-ons API change: PVR API change: Binary add-ons Type: Breaking change fix or feature that will cause existing functionality to change labels Jan 7, 2021
@phunkyfish phunkyfish added this to the Matrix 19.0-RC1 milestone Jan 7, 2021
This was referenced Jan 8, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
ksooo
ksooo requested changes Jan 8, 2021
View reviewed changes
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c/p error needs to be fixed

xbmc/addons/kodi-dev-kit/include/kodi/addon-instance/PVR.h Outdated Show resolved Hide resolved
ksooo
ksooo approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shove it in. :-)

This was referenced Jan 8, 2021
Merged
Merged
Closed
Merged
Merged
This was referenced Jan 8, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
AlwinEsch
AlwinEsch approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@AlwinEsch AlwinEsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the bit long doc lines, looks it very good and nice.
Thanks a lot about!

xbmc/pvr/addons/PVRClients.h Show resolved Hide resolved
xbmc/pvr/addons/PVRClient.h Outdated Show resolved Hide resolved
@phunkyfish phunkyfish mentioned this pull request Jan 8, 2021
Merged
@phunkyfish
Copy link
Contributor Author

jenkins build this please

1 similar comment
@phunkyfish
Copy link
Contributor Author

jenkins build this please

@phunkyfish
Copy link
Contributor Author

jenkins build this please

@phunkyfish
Copy link
Contributor Author

jenkins build this please

1 similar comment
@phunkyfish
Copy link
Contributor Author

jenkins build this please

@phunkyfish
Copy link
Contributor Author

jenkins build this please

@phunkyfish phunkyfish merged commit a8d0039 into xbmc:master Jan 8, 2021
@phunkyfish phunkyfish deleted the epg-timeframe branch January 8, 2021 21:16
@bkuhls bkuhls mentioned this pull request Jan 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlwinEsch AlwinEsch AlwinEsch approved these changes

@ksooo ksooo ksooo approved these changes

Assignees
No one assigned
Labels
API change: Binary add-ons API change: PVR Component: Binary add-ons Component: PVR Type: Breaking change fix or feature that will cause existing functionality to change Type: Feature non-breaking change which adds functionality v19 Matrix
Projects
None yet
Milestone
Matrix 19.0-RC1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phunkyfish @ksooo @AlwinEsch