use the script id, not the plugin name to lookup the script #1962

Merged
merged 1 commit into from Dec 20, 2012

Conversation

Projects
None yet
2 participants
Member

jmarshallnz commented Dec 19, 2012

In CPluginDirectory::WaitOnScriptResult we need to check whether the plugin is still running - to do this we use the plugin name, but if 2 instances are running we get the first one which may not be the one we want. Use the script id instead seeing as we have it. Fixes #13776.

@jimfcarroll to review.

While I don't see any reason why this would do anything odd, it would be nice for this to be in RC2 so we make sure of it.

use the script id, not the plugin name to lookup the script in CPlugi…
…nDirectory::WaitOnScriptResult so we make sure we're waiting on the correct instance. fixes #13776

jmarshallnz added a commit that referenced this pull request Dec 20, 2012

Merge pull request #1962 from jmarshallnz/use_plugin_id_not_name
use the script id, not the plugin name to lookup the script

@jmarshallnz jmarshallnz merged commit 4f76251 into xbmc:master Dec 20, 2012

@jmarshallnz jmarshallnz deleted the jmarshallnz:use_plugin_id_not_name branch Dec 20, 2012

Member

jimfcarroll commented on de76172 Dec 20, 2012

Looks good to me (a little late :-) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment