use the script id, not the plugin name to lookup the script #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nDirectory::WaitOnScriptResult so we make sure we're waiting on the correct instance. fixes xbmc#13776
jmarshallnz
added a commit
that referenced
this pull request
Dec 20, 2012
use the script id, not the plugin name to lookup the script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CPluginDirectory::WaitOnScriptResult we need to check whether the plugin is still running - to do this we use the plugin name, but if 2 instances are running we get the first one which may not be the one we want. Use the script id instead seeing as we have it. Fixes #13776.
@jimfcarroll to review.
While I don't see any reason why this would do anything odd, it would be nice for this to be in RC2 so we make sure of it.