GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
In CPluginDirectory::WaitOnScriptResult we need to check whether the plugin is still running - to do this we use the plugin name, but if 2 instances are running we get the first one which may not be the one we want. Use the script id instead seeing as we have it. Fixes #13776.
@jimfcarroll to review.
While I don't see any reason why this would do anything odd, it would be nice for this to be in RC2 so we make sure of it.
use the script id, not the plugin name to lookup the script in CPlugi…
…nDirectory::WaitOnScriptResult so we make sure we're waiting on the correct instance. fixes #13776
Merge pull request #1962 from jmarshallnz/use_plugin_id_not_name
use the script id, not the plugin name to lookup the script
Looks good to me (a little late :-) )