[Android] Storage Manager: Try fallback to obtain drives if running on Android 6 and older #19803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Fix
|
I'm surprised the fallback doesn't happen in the current version, tbh. |
I messed it up with xbmc/libandroidjni#23 |
|
Ah, right :) |
…n Android 6 and older (SDK API level < 24) or in case of error.
ksooo
force-pushed
the
android-fix-storage-manager
branch
from
f25d49a
to
3873ca7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only use https://developer.android.com/reference/android/os/storage/StorageManager#getStorageVolumes() if running on a device with at least SDK level 24. Otherwise use fallback via
/proc/mounts.Fixes a regression introduced by #19523.
@koying does this look sane?