[PVR][JSON-RPC] Expose EPG tag's series number as 'seasonnum' property. #20003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Fix
|
@ksooo this is a non-breaking interface change so bump JSON minor version e.g. 12.4.0 It is best practice (results can be parsed positionally?) as a non-breaking change that the added field needs to go at the end of the type definition and field enum rather than inserted (in the obvious place ) as you have done. Yes to backporting this as a fixm since we still have v19 and v20 inline with each other. |
ksooo
force-pushed
the
pvr-serialize-epgtag-seasonnum
branch
from
ce70818
to
7551b73
Compare
|
@DaveTBlake thanks, requested changes are now in. |
|
Great, thx @ksooo If you provide a current windows build, i'm ready to test it. But just for my interest: what exactly episodepart is intended for? Is there an equivalent info label for that? |
|
Honestly, I have no idea what episodepart is good for. It was introduced before my Kodi time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details see #19999 (comment)
@phunkyfish when you find some time for a code review...
@DaveTBlake is the JSON-RPC change okay?
BTW, I wouldlike to backport this as I consider it a fix.
@louisbraun fyi