Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SmartRedraw] Fix scrollable fadelabels #20191

Merged
merged 1 commit into from Sep 28, 2021

Conversation

enen92
Copy link
Member

@enen92 enen92 commented Sep 27, 2021

Description

Currently if smartredraw is enabled and a dialog contains a scrollable fade label control, the label doesn't scroll. In some specific scenarios, e.g. with notifications/kaytoast dialogs, the dialog might be left on screen because the label doesn't finish the scrolling process. This makes sure that if the label is scrollable the dialog is refreshed anytime the scrollinfo is updated.

Motivation and context

Fix #18391
Superseeds #19156

How has this been tested?

With python xbmcgui.notifications

What is the effect on users?

None if smartredraw is not enabled. If it is, kaytoasts containing fadelabels should get closed after a while.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@enen92 enen92 added Type: Fix non-breaking change which fixes an issue Component: GUI rendering v20 Nexus labels Sep 27, 2021
@enen92 enen92 added this to the Nexus 20.0 Alpha 1 milestone Sep 27, 2021
@enen92 enen92 requested a review from fuzzard September 27, 2021 18:34
@fuzzard
Copy link
Contributor

fuzzard commented Sep 27, 2021

Test failures on Linux platform unrelated.
And you've had confirmation from original issue reporter/or, so good to go imo

@enen92
Copy link
Member Author

enen92 commented Sep 28, 2021

jenkins build and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CEC adapter notification stuck on screen if smartredraw is enabled
3 participants