Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[smartredraw] Fix dialog progress not being updated #20192

Merged
merged 1 commit into from Sep 28, 2021

Conversation

enen92
Copy link
Member

@enen92 enen92 commented Sep 27, 2021

Description

This fixes progress dialogs not being updated if smartredraw is enabled. If the new percentage differs from the old/stored one, the dialog must be refreshed (dirtyregions set).

Motivation and context

Fix #15354

How has this been tested?

With the video download functionality provided by the Aerial screensaver

What is the effect on users?

DialogProgress should behave decently if smartredraw is enabled

Screenshots (if appropriate):

DialogProgress

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@enen92 enen92 added this to the Nexus 20.0 Alpha 1 milestone Sep 27, 2021
@enen92 enen92 requested a review from fuzzard September 27, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

smartredraw:true doesnt close Library update window
2 participants