Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDL][OSD] Add setting to avoid commbreak notification #20711

Merged
merged 1 commit into from Jan 3, 2022

Conversation

enen92
Copy link
Member

@enen92 enen92 commented Dec 22, 2021

Description

This PR adds an advanced setting to allow the user to avoid showing the edl commbreak notifications (they display by default)

<advancedsettings version="1.0">
        <edl>
		<displaycommbreaknotifications>false</displaycommbreaknotifications>
	</edl>
</advancedsettings>

Motivation and context

Improve EDL usability

How has this been tested?

Runtime tested

What is the effect on users?

They may hide the notification that's shown when reaching EDL blocks.

Screenshots (if appropriate):

image

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@enen92 enen92 added Type: Improvement non-breaking change which improves existing functionality Wiki: Needed v20 Nexus Component: Players For changed player parts within "./xbmc/cores" labels Dec 22, 2021
@enen92 enen92 added this to the Nexus 20.0 Alpha 1 milestone Dec 22, 2021
@enen92 enen92 requested a review from ksooo December 22, 2021 19:20
Copy link
Contributor

@lrusak lrusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look fine 👍

@enen92
Copy link
Member Author

enen92 commented Dec 29, 2021

Merging this as it has lukas "approval"

@enen92
Copy link
Member Author

enen92 commented Dec 29, 2021

jenkins build and merge

system/settings/settings.xml Outdated Show resolved Hide resolved
xbmc/cores/VideoPlayer/VideoPlayer.cpp Outdated Show resolved Hide resolved
@ksooo
Copy link
Member

ksooo commented Dec 30, 2021

Not sure this actually should be a GUI setting. I see this more as an advanced setting, if needed at all, because I consider this a real edge case. Just my 2ct, however.

@enen92 enen92 force-pushed the avoidkaytoastcommbreak branch 2 times, most recently from 614d792 to 87f0b7b Compare December 30, 2021 12:03
@enen92 enen92 closed this Dec 30, 2021
@enen92 enen92 reopened this Dec 30, 2021
@enen92
Copy link
Member Author

enen92 commented Dec 30, 2021

There was one place missing where this notification was also triggered: if it started right at second 0 (demuxer initial position). Adjusted on the last revision and squashed.

@enen92 enen92 requested a review from ksooo December 30, 2021 17:37
@enen92 enen92 added the WIP PR that is still being worked on label Jan 2, 2022
@enen92
Copy link
Member Author

enen92 commented Jan 2, 2022

Will move this to an advanced setting.

Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enen92 enen92 removed the WIP PR that is still being worked on label Jan 3, 2022
@enen92
Copy link
Member Author

enen92 commented Jan 3, 2022

changed to m_EdlDisplayCommbreakNotifications for consistency on the last force-push (no functional changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Players For changed player parts within "./xbmc/cores" Type: Improvement non-breaking change which improves existing functionality v20 Nexus Wiki: Done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants