New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EDL][OSD] Add setting to avoid commbreak notification #20711
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look fine 👍
Merging this as it has lukas "approval" |
jenkins build and merge |
Not sure this actually should be a GUI setting. I see this more as an advanced setting, if needed at all, because I consider this a real edge case. Just my 2ct, however. |
614d792
to
87f0b7b
Compare
87f0b7b
to
e58f3b1
Compare
There was one place missing where this notification was also triggered: if it started right at second 0 (demuxer initial position). Adjusted on the last revision and squashed. |
Will move this to an advanced setting. |
e58f3b1
to
196c4c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
196c4c2
to
32459df
Compare
changed to |
Description
This PR adds an advanced setting to allow the user to avoid showing the edl commbreak notifications (they display by default)
Motivation and context
Improve EDL usability
How has this been tested?
Runtime tested
What is the effect on users?
They may hide the notification that's shown when reaching EDL blocks.
Screenshots (if appropriate):
Types of change
Checklist: