Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pvr] Season and episode sorting for PVR recordings #20790

Merged
merged 2 commits into from Jan 4, 2022

Conversation

phunkyfish
Copy link
Contributor

@phunkyfish phunkyfish commented Jan 4, 2022

Description

Adds a sort method based on season and episode to PVR recordings. Thanks @ksooo who provided the solution, just testing on my part ;)

Note that there is a bug in the GUI refresh of the secondary sort method (datetime) when it is changed in the UI which needs to be solved separately to this PR. #20792

Motivation and context

There is currently no sort method based on season and episode for PVR recordings, this PR adds one. This has been discussed on the forum: https://forum.kodi.tv/showthread.php?tid=353273.

While this can be thought of as a feature, it is also a bug as it forces PVR add-ons to workaround this:

With this sort method in place, the workarounds can be removed in the add-ons leaving any display semantics to the skin as it should be.

How has this been tested?

OSX Monterrey using pvr.vuplus.

What is the effect on users?

Screenshots (if appropriate):

With new sort method, note that the season/episode in the title string is handled by the skin:

Screenshot 2022-01-04 at 10 57 54

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@phunkyfish phunkyfish requested a review from ksooo as a code owner January 4, 2022 10:51
@phunkyfish phunkyfish added Component: PVR Type: Feature non-breaking change which adds functionality Type: Fix non-breaking change which fixes an issue v20 Nexus labels Jan 4, 2022
@phunkyfish phunkyfish added this to the Nexus 20.0 Alpha 1 milestone Jan 4, 2022
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phunkyfish phunkyfish merged commit 56530f2 into xbmc:master Jan 4, 2022
@phunkyfish phunkyfish deleted the rec-episode-sort branch January 4, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport: Done Component: PVR Type: Feature non-breaking change which adds functionality Type: Fix non-breaking change which fixes an issue v20 Nexus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants