Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[subtitles] Fix CC condition for valid captions #21410

Merged
merged 1 commit into from
May 17, 2022
Merged

Conversation

enen92
Copy link
Member

@enen92 enen92 commented May 16, 2022

Description

"Borrowed" from VLC (videolan/vlc@67dd763) this attempts to fix the condition used to let the demuxing of closed captions proceed.

Motivation and context

A user reported the bug and provided a sample file in https://forum.kodi.tv/showthread.php?tid=368221
Kodi is unable to show those captions while vlc or mpv play them without any issues.

How has this been tested?

Runtime tested, played some samples I knew Kodi was able to handle before + the failing one.

What is the effect on users?

Some CC subs that were previously not playing should now be playable.

Screenshots (if appropriate):

Master:
image
Screenshot from 2022-05-16 16-12-27

PR:
image

Screenshot from 2022-05-16 16-10-59

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@enen92 enen92 added this to the Nexus 20.0 Alpha 2 milestone May 16, 2022
@enen92 enen92 requested a review from CastagnaIT May 16, 2022 15:16
Copy link
Collaborator

@CastagnaIT CastagnaIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have been circling this issue for a long time

now CC subtitles works also with InputStreamAdaptive
tested with: https://livesim.dashif.org/dash/vod/testpic_2s/cea608.mpd
great!

PS. please PM me the CC sample video i am not able download it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants