Don't require Spline36 and Lanczos3 scalers to be enabled through advancedsettings.xml

[smp79]

Description

This change will allow Spline36 and Lanczos3 without "enablehighqualityhwscalers" option in advancedsettings.xml.

Motivation and context

Those scalers were hidden in advancedsettings.xml more than 10 years ago. Nowadays, a relatively low end hardware can use them without an issue - e.g. my Celeron 6305 can do 1080->4K @60Hz Spline36/Lanczos3 without breaking a sweat. No need to keep it buried in advancedsettings.xml anymore.

How has this been tested?

Tested on Linux x86 (GLES).

What is the effect on users?

Screenshots (if appropriate):

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• None of the above (please explain below)

Checklist:

• My code follows the Code Guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the Contributing document
• I have added tests to cover my change
• All new and existing tests passed

[garbear]

I was a bit confused about the logic of this change at first but now I realize it clearly makes sense.

I always see having one less setting as purely a win.

Not to mention how beautiful a diff reads with 0 lines added 19 removed.

Thanks!

[enen92]

jenkins build this please

[thexai]

In Windows it is already like this

[lrusak]

I'm a little hesitant about the GLES path as a lot of low power devices (think RPi2) may use it. That path isn't used for HW video decode though on that platform so it's likely ok as you likely don't want SW decode and these scalers.

[smp79]

That path isn't used for HW video decode though on that platform so it's likely ok

I suspect that RPi2 would choke on anything other than Nearest Neighbor/Bilinear anyway.

[sarbes]

I suspect that RPi2 would choke on anything other than Nearest Neighbor/Bilinear anyway.

Second that.

[lrusak]

Fine other than my suggestions.

[fuzzard]

Thanks for the PR

[KarellenX]

@smp79

Could you please explain the change to the as.xml file so I can update the wiki.
https://kodi.wiki/view/Advancedsettings.xml#video

<enablehighqualityhwscalers>true</enablehighqualityhwscalers>
Has this setting been removed completely?

[smp79]

Yes, it was completely removed

[KarellenX]

Thanks. I'll update the page now.
(yep, a bit overdue ;) )