Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] add some clarifications on code formatting #21971

Merged
merged 1 commit into from Oct 4, 2022
Merged

[docs] add some clarifications on code formatting #21971

merged 1 commit into from Oct 4, 2022

Conversation

jjlin
Copy link
Contributor

@jjlin jjlin commented Oct 4, 2022

Add some clarifications on the clang-format patches provided by the PR build job, and on the rules for mixing code and cosmetic changes.

This will hopefully help avoid unnecessary back and forth with new contributors, as in #21966.

@fuzzard fuzzard added this to the Nexus 20.0 Beta 1 milestone Oct 4, 2022
ksooo
ksooo approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. This definitely improves the documentation.

@ksooo ksooo added the hacktoberfest-accepted Hacktoberfest tagging label Oct 4, 2022
@fuzzard fuzzard merged commit 311ef98 into xbmc:master Oct 4, 2022
@jjlin jjlin deleted the contrib-docs branch October 4, 2022 16:01
@garbear
Copy link
Member

garbear commented Oct 4, 2022

Great clarifications, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksooo ksooo ksooo approved these changes

Assignees
No one assigned
Labels
Documentation hacktoberfest-accepted Hacktoberfest tagging v20 Nexus
Projects
None yet
Milestone
Nexus 20.0 Beta 1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jjlin @garbear @ksooo @fuzzard