New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[upnp]: add all KODI supported real subtitle formats when act as a DLNA render #22038
[upnp]: add all KODI supported real subtitle formats when act as a DLNA render #22038
Conversation
3305fc0
to
5c7f320
Compare
5c7f320
to
8b9fd24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the contribution and for fixing this. Left a few comments where I think this can be improved
53e0d68
to
f4f7301
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please squash the commits
…and share the white list with the kodi DLNA server
f4f7301
to
5a7c335
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks will be merged once jenkins gets green
It's building a merge commit of yours on top of the master head commit: |
…n act as a DLNA render,this is a backport of xbmc#22038
… render this is a backport of xbmc/xbmc#22038
upnp: add all KODI supported real subtitle formats when act as a DLNA render
and share the white list with the KODI DLNA server
Description
Motivation and context
Reading :
EMBY can "DLNA" a movie along with all it's subtitle to KODI
But, the white list of subtitle of DLNA media render is outdated
so KODI will reject all the subtitle not in the list,such as ass/ssa
which makes the subtitle function broken
How has this been tested?
local build pass and tested with emby dlna server,all subttitles functional
local build pass and tested with Bubble upnp app
What is the effect on users?
user will have a full functional subtitle selection when play video by supported DLNA control point
Screenshots (if appropriate):
Types of change
Checklist: