New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tools/depends][target] Bump gnutls 3.7.8 #22304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a standard dependency bump, and I even see some improvements by moving gnutls-specific config to its Makefile.
If we change DEFAULT_NDK_API=23 we are raising the minimum compatibility to devices with API level 23 |
I'm fully aware. Im just confirming on Jenkins the issue with < API 23 isn't tied to ndk. This will be shelved, as well as other bumps relying on gnutls 3.7+ (at least samba 3.17) until we raise minimum SDK api |
Sorry, I didn't see that it was a test to confirm that API level 23 solved a compilation issue (in src/gl/fpending.c) |
A proposal, if we change line 44 in return fp_->_p - fp_->_bf._base; @fuzzard add a patch about this joseluismarti@774de5c |
@joseluismarti are you able to runtime and check this is ok for your testing now? |
Seems to work perfectly on x86 playing a SSL stream with ffmpeg |
Description
Bump gnutls 3.7.8
Motivation and context
Samba 4.17 requires gnutls 3.7.2 as a minimum.
Bump this separately for easier testing
How has this been tested?
Build run macos apple silicon. Accessing https resource, playback media via IA based addon
What is the effect on users?
Hopefully nothing
Screenshots (if appropriate):
Types of change
Checklist: