Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools/depends][target] Bump gnutls 3.7.8 #22304

Merged
merged 2 commits into from Mar 11, 2023
Merged

Conversation

fuzzard
Copy link
Contributor

@fuzzard fuzzard commented Dec 22, 2022

Description

Bump gnutls 3.7.8

Motivation and context

Samba 4.17 requires gnutls 3.7.2 as a minimum.
Bump this separately for easier testing

How has this been tested?

Build run macos apple silicon. Accessing https resource, playback media via IA based addon

What is the effect on users?

Hopefully nothing

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

Copy link
Member

@garbear garbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a standard dependency bump, and I even see some improvements by moving gnutls-specific config to its Makefile.

@joseluismarti
Copy link
Contributor

If we change DEFAULT_NDK_API=23 we are raising the minimum compatibility to devices with API level 23

@fuzzard
Copy link
Contributor Author

fuzzard commented Dec 22, 2022

I'm fully aware. Im just confirming on Jenkins the issue with < API 23 isn't tied to ndk.

This will be shelved, as well as other bumps relying on gnutls 3.7+ (at least samba 3.17) until we raise minimum SDK api

@joseluismarti
Copy link
Contributor

Sorry, I didn't see that it was a test to confirm that API level 23 solved a compilation issue (in src/gl/fpending.c)

@joseluismarti
Copy link
Contributor

joseluismarti commented Dec 23, 2022

A proposal, if we change line 44 in src/gl/fpending.c to

  return fp_->_p - fp_->_bf._base;

@fuzzard add a patch about this joseluismarti@774de5c

@joseluismarti joseluismarti mentioned this pull request Dec 27, 2022
13 tasks
@jenkins4kodi jenkins4kodi added the Rebase needed PR that does not apply/merge cleanly to current base branch label Mar 8, 2023
@jenkins4kodi jenkins4kodi removed the Rebase needed PR that does not apply/merge cleanly to current base branch label Mar 10, 2023
@fuzzard fuzzard closed this Mar 11, 2023
@fuzzard fuzzard reopened this Mar 11, 2023
@fuzzard
Copy link
Contributor Author

fuzzard commented Mar 11, 2023

@joseluismarti are you able to runtime and check this is ok for your testing now?

@joseluismarti
Copy link
Contributor

@joseluismarti are you able to runtime and check this is ok for your testing now?

Seems to work perfectly on x86 playing a SSL stream with ffmpeg

@fuzzard fuzzard merged commit 73049ad into xbmc:master Mar 11, 2023
@fuzzard fuzzard deleted the depends_gnutls branch March 11, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants