EndTime: fix overflow when doing large comparisons #22471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritsch
added
v20 Nexus
Type: Backport
Type: Fix
|
Is need also backport of #22416 to avoid int overflow here: |
The struct member rename isn't needed but it makes it more clear that the value is in minutes from an int Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
… casted to templated type This is required because we use the default std::chrono::steady_clock::duration which typically is std::chrono::nanoseconds. When comparing durations the templated type may overflow when comparing to std::chrono::nanoseconds. std::chrono::nanoseconds::max() on my platform works out to ~292 years Signed-off-by: Lukas Rusak <lorusak@gmail.com>
…eaming Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
…s silence timeout This is required because the setting itself is stored as an int. The int represents minutes and when converted to std::chrono::minutes will overflow std::chrono::nanoseconds which is the units of the timer.
fritsch
force-pushed
the
lrusak-endtime
branch
from
b323ac1
to
de1d974
Compare
|
@thexai Thanks much, that one slipped through. |
lrusak
approved these changes
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of: #22452 and #22416 as they both logically belong together.