Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] Retroplayer: Savestate manager fixes #22517

Merged
merged 5 commits into from Jan 25, 2023

Conversation

KOPRajs
Copy link
Contributor

@KOPRajs KOPRajs commented Jan 18, 2023

Description

This is a backport of #22490 to Nexus.

I was originally hoping to have this merged by the time the Nexus is released, but better late than never.

Motivation and context

How has this been tested?

What is the effect on users?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@KOPRajs KOPRajs requested a review from garbear as a code owner January 18, 2023 15:40
@KOPRajs KOPRajs changed the title [Nexus] [Retroplayer] Savestate manager fixes [Nexus] Retroplayer: Savestate manager fixes Jan 19, 2023
@KOPRajs KOPRajs force-pushed the savestate-manager-fixes-nexus branch 2 times, most recently from b78cbc7 to 2d159f0 Compare January 23, 2023 19:40
@KOPRajs KOPRajs force-pushed the savestate-manager-fixes-nexus branch from 2d159f0 to 067e607 Compare January 24, 2023 15:40
@KOPRajs KOPRajs changed the title [Nexus] Retroplayer: Savestate manager fixes [Backport] Retroplayer: Savestate manager fixes Jan 24, 2023
@KOPRajs KOPRajs changed the title [Backport] Retroplayer: Savestate manager fixes [backport] Retroplayer: Savestate manager fixes Jan 24, 2023
@garbear garbear added this to the Nexus 20.1 milestone Jan 24, 2023
@KOPRajs KOPRajs force-pushed the savestate-manager-fixes-nexus branch from 067e607 to a444ff1 Compare January 24, 2023 21:20
@garbear
Copy link
Member

garbear commented Jan 25, 2023

I've tested this PR on my Nexus branch with the changes in #22585 applied. Everything works as expected so far.

@garbear garbear merged commit f8bcbfc into xbmc:Nexus Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Games Type: Backport Type: Fix non-breaking change which fixes an issue v20 Nexus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants