[favourites][keymaps] Favourites Browser window: Catch-up on features of the deprecated Favourites dialog #22602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Improvement
ksooo
changed the title
enen92
approved these changes
Jan 28, 2023
If somebody comes up with a cool concept for the need to share code for GUI actions between windows/dialogs/context menus/builtins, to avaoid duplicate code, I will be happy to adapt. |
…ons up/down/delete to catch up up with the functionality of the now deprecated Favourites dialog
ksooo
force-pushed
the
favourites-feature-catch-up
branch
from
b1f6f04
to
65ebd50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR catches up on the features of the deprecated Favourites dialog, that were simply forgotten to implement in the first place:
Was requested in the forum: https://forum.kodi.tv/showthread.php?tid=371608
Runtime-tested on macOS and Android, latest Kodi master.
@enen92 not sure you are the right person to review?
@fuzzard I want to backport this as i consider the missing functionality a regression.