Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keymap] add settings-window shortcut #22624

Merged
merged 1 commit into from Feb 9, 2023
Merged

Conversation

DaVukovic
Copy link
Member

Description

Add a shortcut to enter the Kodi settings

Motivation and context

Some skins provide the option to disable various menu items. One is able to disable the "settings"-button as well to enter the Kodi settings. For what I can tell, disabling the settings-button is mostly not done on purpose. It happens via accident and for some ppl it's somewhat hard to revert this change.

Sure one is able to edit the settings.xml (if they know how the setting is named) or use kodi-send -a "ActivateWindow(Settings) or use the JSON API....but I think this might be way easier

How has this been tested?

`

Compiled and tested on Fedora

What is the effect on users?

Users are able to access the settings via a keyboard by pressing alt + s

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@DaVukovic DaVukovic added Type: Improvement non-breaking change which improves existing functionality Component: Input labels Jan 29, 2023
@DaVukovic DaVukovic added this to the Omega 21.0 Alpha 1 milestone Jan 29, 2023
Copy link
Contributor

@fuzzard fuzzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

Copy link
Member

@garbear garbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keyboard shortcut proliferation could be undesirable, but in this case a settings-window shortcut seems needed to recover from some skins.

@fuzzard fuzzard merged commit 53e7777 into xbmc:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Input Type: Improvement non-breaking change which improves existing functionality v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants