-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools/depends: native build fixes and improvements #22780
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrusak
added
Type: Fix
non-breaking change which fixes an issue
Platform: Linux
Component: Depends
v21 Omega
labels
Feb 15, 2023
fuzzard
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok to me.
@wsnipex all good? |
wsnipex
reviewed
Apr 12, 2023
lrusak
force-pushed
the
depends-native-fixes
branch
2 times, most recently
from
April 16, 2023 20:28
0ab1556
to
90a22a9
Compare
squashed the fixup and updated the commit message for 88f761d |
jenkins4kodi
added
the
Rebase needed
PR that does not apply/merge cleanly to current base branch
label
Apr 20, 2023
lrusak
force-pushed
the
depends-native-fixes
branch
from
April 20, 2023 15:43
90a22a9
to
3740da5
Compare
jenkins4kodi
added
Rebase needed
PR that does not apply/merge cleanly to current base branch
and removed
Rebase needed
PR that does not apply/merge cleanly to current base branch
labels
Apr 20, 2023
… instead) Signed-off-by: Lukas Rusak <lorusak@gmail.com>
….txt instead) Signed-off-by: Lukas Rusak <lorusak@gmail.com>
…TIONS Signed-off-by: Lukas Rusak <lorusak@gmail.com>
…uild Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
… build Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
…uild Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
…ive build Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
lrusak
force-pushed
the
depends-native-fixes
branch
from
April 22, 2023 02:51
3740da5
to
002c2e3
Compare
jenkins4kodi
removed
the
Rebase needed
PR that does not apply/merge cleanly to current base branch
label
Apr 22, 2023
all good? |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspired by #22773 this fixes the build for native builds and adds some improvements (like using
lib
instead oflib64
).Should be pretty straight forward. The only one I think that deserves attention is the texturepacker native build. I don't think it's expected for people to have static versions of liblzo2, libgif, libjpeg, etc.
I used the following script to build these:
sample dir:
maybe we should add a CI build job for this?