[BP] [jenkins][Apple] Some fixes for apple buildsteps #22958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 11, 2023 11:22
With the new Build system in xcode, it now has a changed behaviour with a new setting "Based on dependency analysis". For us, essentially our dependency targets (eg fmt, spdlog, etc) are added as Run scripts by the cmake xcode generator. This means that any dep added as a run script will always be exectuted. Currently with master buildsteps make-xbmc builds the build target, and then the package step building the deb target, dependencies are built twice regardless of state. We will have to look into the cmake generation side of things but the easiest solution for now is to just generate the deb target as part of the make-xbmc buildstep, and then just handle upload of artifact in the package buildstep. Shaves off ~3 minutes of build time on jenkins.
This was referenced Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #22710
Motivation and context
How has this been tested?
What is the effect on users?
Screenshots (if appropriate):
Types of change
Checklist: