Python API: Add ability to set infotags #23055
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since
ListItem.setInfo
was deprecated, we moved to managing metadata via infotags.However, the memory ownership model of infotags makes things brittle, because you're not guaranteed a reference to the underlying listitem's memory. Therefore, setting metadata on infotags isn't guaranteed to update the underlying listitem, breaking our alternative to
setInfo
in v20.To work around this, simply add infotag setters.
Motivation and context
Fixes #23042
How has this been tested?
Testing in progress. Will upload test builds.
Types of change