Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python API: Add ability to set infotags #23055

Closed
wants to merge 1 commit into from

Conversation

garbear
Copy link
Member

@garbear garbear commented Mar 25, 2023

Description

Since ListItem.setInfo was deprecated, we moved to managing metadata via infotags.

However, the memory ownership model of infotags makes things brittle, because you're not guaranteed a reference to the underlying listitem's memory. Therefore, setting metadata on infotags isn't guaranteed to update the underlying listitem, breaking our alternative to setInfo in v20.

To work around this, simply add infotag setters.

Motivation and context

Fixes #23042

How has this been tested?

Testing in progress. Will upload test builds.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Needed since the deprecation of ListItem.setInfo.
@xbmc xbmc deleted a comment from jenkins4kodi Mar 26, 2023
@garbear
Copy link
Member Author

garbear commented Mar 30, 2023

Closing, going to take a different approach

@garbear garbear closed this Mar 30, 2023
@garbear garbear deleted the add-infotag-setters branch July 9, 2023 06:02
@fuzzard fuzzard removed the v21 Omega label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change: Python Component: Python Type: Fix non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setGameClient does not consistently work
2 participants