[Android] Listen to default network changes #23059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enen92
added
Type: Improvement
joseluismarti
force-pushed
the
NetworkCallback
branch
from
c04e204
to
43c3356
Compare
joseluismarti
force-pushed
the
NetworkCallback
branch
from
43c3356
to
98f0aef
Compare
jenkins4kodi
added
the
Rebase needed
joseluismarti
force-pushed
the
NetworkCallback
branch
from
4922a89
to
85cd338
Compare
jenkins4kodi
removed
the
Rebase needed
joseluismarti
force-pushed
the
NetworkCallback
branch
from
85cd338
to
0c3231b
Compare
enen92
reviewed
May 12, 2023
enen92
reviewed
May 12, 2023
xbmc/platform/android/activity/JNIXBMCConnectivityManagerNetworkCallback.cpp
Outdated
Show resolved
Hide resolved
xbmc/platform/android/activity/JNIXBMCConnectivityManagerNetworkCallback.cpp
Outdated
Show resolved
Hide resolved
enen92
reviewed
May 12, 2023
joseluismarti
force-pushed
the
NetworkCallback
branch
from
0c3231b
to
597010e
Compare
lrusak
reviewed
May 13, 2023
| { | ||
| CJNINetworkInterface intf = CJNINetworkInterface::getByName(lp.getInterfaceName()); | ||
| if (intf) | ||
| m_defaultInterface = new CNetworkInterfaceAndroid(n, lp, intf); |
There was a problem hiding this comment.
I don't see a delete to this new. Maybe use std::unique_ptr instead?
There was a problem hiding this comment.
I've tried, but this class is common to all platforms and copy operations are done in other parts of the code... with a delete would be fine
There was a problem hiding this comment.
Since m_defaultInterface is local to this class I don't see a problem. You can use .get() to return the raw pointer in functions that need CNetworkInteface*
There was a problem hiding this comment.
I tried again as you indicated and it works, please tell me if I forgot anything, thanks
joseluismarti
force-pushed
the
NetworkCallback
branch
from
597010e
to
eaa7b8f
Compare
enen92
approved these changes
May 13, 2023
joseluismarti
force-pushed
the
NetworkCallback
branch
from
eaa7b8f
to
0d1b363
Compare
|
Good to go? |
|
Looks good to me |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All apps in a device use a default network, which is determined by the system. The network that is set as the default can change at any time. A typical example is the device coming within range of a known Wi-Fi access point. The device disconnects from the mobile network, connects to the access point and switches the default network.
The purpose of this PR is that Kodi listens to network status changes, so that if the device changes the default network, the app will do so as well.
To receive notifications of network events, use the NetworkCallback class together with
ConnectivityManager.registerDefaultNetworkCallback(NetworkCallback)
The
CNetworkAndroidclass will always keep the reference to the default network.Depends on xbmc/libandroidjni#46
Types of change
Checklist: