Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] improve Dolby Vision compatibility #23079

Merged
merged 1 commit into from Mar 31, 2023

Conversation

thexai
Copy link
Member

@thexai thexai commented Mar 30, 2023

Description

Improve Dolby Vision compatibility

Motivation and context

Follow up of #22950

While the previous PR improved the compatibility of profiles 4 and 5 with devices that do not have a DV display, it has also caused regressions with Dolby Vision profiles 7, 8 and devices that normally work well with HDR10 fallback.

This is very important use case as all BD remuxes that come from commercial UHD Blu-Ray's has DV profile 7 with HDR10 fallback (or profile 8 if it has been converted with some tool).

See #22950 (comment) and #22950 (comment)

How has this been tested?

Tested Shield Pro 2019 with Dolby Vision Shield setting disabled.
Tested various BDremux (DV profile 7) and demo clips (DV profile 8) mkv and mp4.
Confirmed output picture is HDR10 on TV and in Kodi Player Info video decoder used is amc-hevc(s) HW

What is the effect on users?

Improve Dolby Vision compatibility with devices that are not DV capable but has HDR10 capabilities.
At same time maintains the improvements of the previous PR for devices that are capable of HW tone mapping Dolby Vision profile 4, 5 to SDR.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@thexai thexai added Type: Fix non-breaking change which fixes an issue Type: Improvement non-breaking change which improves existing functionality Component: Video rendering Platform: Android v21 Omega labels Mar 30, 2023
@thexai thexai added this to the Omega 21.0 Alpha 1 milestone Mar 30, 2023
@thexai thexai requested a review from fritsch March 30, 2023 10:14
@thexai
Copy link
Member Author

thexai commented Mar 30, 2023

@joseluismarti
Copy link
Contributor

I have tested this change on the Fire TV Stick 4K Max on a TV that does not support Dolby and I get the same quality with the hevc decoder as with dvhe, I have tried several sample videos of profile 5, 7 and 8.

If on other devices you get a quality improvement by using hevc on Dovi>5 profiles, it seems like a good solution.

Copy link
Member

@fritsch fritsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks much.

@thexai thexai merged commit 847a347 into xbmc:master Mar 31, 2023
1 check passed
@thexai thexai deleted the dovi-compatibility branch March 31, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Video rendering Platform: Android Type: Fix non-breaking change which fixes an issue Type: Improvement non-breaking change which improves existing functionality v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants