Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Python API: Fix setting picture/game info via InfoTags #23094

Merged
merged 1 commit into from
Apr 10, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 2 additions & 6 deletions xbmc/interfaces/legacy/ListItem.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -901,17 +901,13 @@ namespace XBMCAddon
xbmc::InfoTagPicture* ListItem::getPictureInfoTag()
{
XBMCAddonUtils::GuiLock lock(languageHook, m_offscreen);
if (item->HasPictureInfoTag())
return new xbmc::InfoTagPicture(item->GetPictureInfoTag(), m_offscreen);
return new xbmc::InfoTagPicture();
return new xbmc::InfoTagPicture(item->GetPictureInfoTag(), m_offscreen);
}

xbmc::InfoTagGame* ListItem::getGameInfoTag()
{
XBMCAddonUtils::GuiLock lock(languageHook, m_offscreen);
if (item->HasGameInfoTag())
return new xbmc::InfoTagGame(item->GetGameInfoTag(), m_offscreen);
return new xbmc::InfoTagGame();
return new xbmc::InfoTagGame(item->GetGameInfoTag(), m_offscreen);
}

std::vector<std::string> ListItem::getStringArray(const InfoLabelValue& alt,
Expand Down