[Windows] minor refactor of DXVAHD

[thexai]

Description

Minor refactor of DXVAHD

Motivation and context

• Avoids many calls to DX::Windowing()->UseLimitedColor()
• No functional changes

How has this been tested?

Runtime Windows x64

What is the effect on users?

nothing

Screenshots (if appropriate):

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• None of the above (please explain below)

Checklist:

• My code follows the Code Guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the Contributing document
• I have added tests to cover my change
• All new and existing tests passed

[CrystalP]

not static anymore? I think it's good it doesn't rely on class members.

[thexai]

Removed static as seems a bit confusing due calls others methods inside. In the other hand GetDXGIColorSpaceSource is self contained as not calls others methods. But actually the two methods could be static or not.

[CrystalP]

Saving a call and reducing coupling is a good idea.
I will give it a whirl just in case.

[CrystalP]

No surprise, the behavior is the same before/after, so approved for me.
Unfortunately in my case it means that with limited range output, dxva fails all the formats I tried.

edit: reason is that the AMD processor doesn't support ANY DXGI_COLOR_SPACE_RGB_STUDIO as output.

[thexai]

Unfortunately in my case it means that with limited range output, dxva fails all the formats I tried.

edit: reason is that the AMD processor doesn't support ANY DXGI_COLOR_SPACE_RGB_STUDIO as output.

In the forum there are multiple examples of people using AMD and limited range with HDR10 I remember it in the thread when HDR was implemented in Windows (https://forum.kodi.tv/showthread.php?tid=349861) I would have to look for the posts. In any case this is not relevant for this PR.

[CrystalP]

I don't doubt it and it wouldn't be surprising that different AMD GPU generations, models, and maybe even different driver versions have different support (range, but other things as well)