DRMPRIME: Check for FFMPEG support

[sundermann]

Description

libdrm prime is not available on webOS but is enabled by default

Motivation and context

How has this been tested?

LG OLED77C28 (webOS 7)

What is the effect on users?

Disabling a broken option in player settings (enabling leads to crash on start of a video)

Screenshots (if appropriate):

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• None of the above (please explain below)

Checklist:

• My code follows the Code Guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the Contributing document
• I have added tests to cover my change
• All new and existing tests passed

[fuzzard]

Might be time to not include https://github.com/xbmc/xbmc/blob/master/cmake/platform/linux/wayland.cmake at

xbmc/cmake/platform/linux/webos.cmake

Line 1 in 5300149

include(${CMAKE_SOURCE_DIR}/cmake/platform/${CORE_SYSTEM_NAME}/wayland.cmake)

Theres not that much in wayland.cmake.

Does webos use GL or GLES, or is it possible to use either?
Does webos use VAAPI?

The rest (PLATFORM_REQUIRED_DEPS except libDRM of course) can just be duplicated imo

[sundermann]

There is only GLES and no VAAPI.

[fuzzard]

something like the following. (assuming you need generate-wayland-extra-protocols?)

list(APPEND PLATFORM_REQUIRED_DEPS OpenGLES EGL WaylandProtocols>=1.7 Waylandpp>=0.2.2  Xkbcommon>=0.4.1 WaylandProtocolsWebOS)
list(APPEND PLATFORM_GLOBAL_TARGET_DEPS generate-wayland-extra-protocols generate-wayland-webos-protocols)

set(WAYLAND_EXTRA_PROTOCOL_GENERATED_DIR "${CMAKE_CURRENT_BINARY_DIR}")
# for wayland-extra-protocols.hpp
include_directories("${WAYLAND_EXTRA_PROTOCOL_GENERATED_DIR}")

# add wayland as platform, as we require it.
# saves reworking other assumptions for linux windowing as the platform name.
list(APPEND CORE_PLATFORM_NAME_LC wayland)

list(APPEND ARCH_DEFINES -DTARGET_WEBOS)
set(TARGET_WEBOS TRUE)
set(PREFER_TOOLCHAIN_PATH ${TOOLCHAIN}/${HOST}/sysroot)

You may want to alter the minimum versions of the various required deps to suit as well, because you no longer have to match the generic linux versions.

[sundermann]

It seems there was a problem with my build setup locally and it seemingly build. LibDRM seems to be used in a lot of places and removing it using ifdefs completely seems like a worse option than just disabling the DRM Prime renderer which is crashing on webOS when enabled.

[fuzzard]

@lrusak i know the ifdeffery will send you crazy. Any ideas on a better architectural way to handle this?

[sundermann]

What about creating a static query function for platforms?

[lrusak]

Look ok, I can test it later.

[lrusak]

I tested this and it seems to work ok. I get the settings available when libdrm is present in FFmpeg. I just made a couple small comments that I would like to see addressed before merging.

[sundermann]

I have applied your suggestions

[wsnipex]

jenkins build this please