TexturePacker: first pass at modernization #23150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
we can now use RAII style alloc/dealloc for the image data with std::vector Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
lrusak
added
Type: Improvement
neo1973
approved these changes
Apr 16, 2023
Comment on lines
+53
to
+54
| frame.rgbaImage.pixels.resize(frameSize); | ||
| memcpy(frame.rgbaImage.pixels.data(), extractedFrames[i]->m_pImage, frameSize); |
There was a problem hiding this comment.
Suggested change
| frame.rgbaImage.pixels.resize(frameSize); | |
| memcpy(frame.rgbaImage.pixels.data(), extractedFrames[i]->m_pImage, frameSize); | |
| frame.rgbaImage.pixels.assign(extractedFrames[i]->m_pImage, | |
| extractedFrames[i]->m_pImage + frameSize); |
There was a problem hiding this comment.
Nice catch! Yes I have another comkit for the next PR that changes m_pImage to be a vector also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass at modernizing TexturePacker. I have a large string of commits but wanted to break up the PR's to allow for easier reviewing.
This mostly changes allocation/deletions to use
std::vectorandstd::unique_ptr. This also allows us to useDecoderManageras a proper class and use RAII to allocate resources.The created
addons/skin.estuary/media/Textures.xbtfile has the same sha256sum before and after this PR.What is the effect on users?
None, purely code cleanup