[PVR] Fix last opened group not always restored on Kodi startup. #23164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Fix
ksooo
force-pushed
the
pvr-fix-restore-last-opened-group
branch
from
deac6f3
to
d0a7f30
Compare
ksooo
changed the title
phunkyfish
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22591.
Last opened channel group must be re-evaluated whenever a new pvr client comes online, because this client may provide the last opened channel group. Only happens in certain (multi-pvr-client) setups.
Runtime-tested on macOS, latest Kodi master, in a multi-pvr-client environment, where this problem could be reproduced reliably.
@phunkyfish whenever you find some time for a review. Should be straight forward. ;-)