Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDRMObject: return std::optional for GetPropertyValue #23169

Merged
merged 1 commit into from
Apr 19, 2023
Merged

CDRMObject: return std::optional for GetPropertyValue #23169

merged 1 commit into from
Apr 19, 2023

Conversation

lrusak
Copy link
Contributor

@lrusak lrusak commented Apr 18, 2023

This makes CDRMObject::GetPropertyValue return a std::optional<uint64_t> instead of std::tuple<bool, uint64>.

This makes it more readable (IMO).

What is the effect on users?

none

@lrusak
CDRMObject: return std::optional for GetPropertyValue
8d5b225 
Signed-off-by: Lukas Rusak <lorusak@gmail.com>
@lrusak lrusak added Type: Improvement non-breaking change which improves existing functionality Platform: Linux Component: Windowing v21 Omega labels Apr 18, 2023
@lrusak lrusak added this to the Omega 21.0 Alpha 2 milestone Apr 18, 2023
@lrusak lrusak requested a review from neo1973 April 18, 2023 03:15
neo1973
neo1973 approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@neo1973 neo1973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes it more readable (IMO).

Absolutely 🙂

@lrusak lrusak merged commit cee3f82 into xbmc:master Apr 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neo1973 neo1973 neo1973 approved these changes

Assignees
No one assigned
Labels
Component: Windowing Platform: Linux Type: Improvement non-breaking change which improves existing functionality v21 Omega
Projects
None yet
Milestone
Omega 21.0 Alpha 2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lrusak @neo1973