Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CVariant] Fix empty() for Null-CVariant #23181

Merged
merged 2 commits into from Apr 21, 2023

Conversation

neo1973
Copy link
Member

@neo1973 neo1973 commented Apr 21, 2023

Description

CVariant::empty() has to return true for a Null-CVariant. This accidentally broke in #23114 728b396. This PR restores the correct bahaviour and extends the unit test for that case.

The problem was first observed in xbmc/Official-Kodi-Remote-iOS#877.

Motivation and context

Restore the correct behaviour.

How has this been tested?

The curl request in xbmc/Official-Kodi-Remote-iOS#877 (comment) creates the expected output. Also there is a better unit test now.

What is the effect on users?

This could cause issues in many places.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@neo1973 neo1973 added Type: Fix non-breaking change which fixes an issue v21 Omega labels Apr 21, 2023
@neo1973 neo1973 added this to the Omega 21.0 Alpha 2 milestone Apr 21, 2023
@neo1973 neo1973 requested a review from howie-f April 21, 2023 13:10
Copy link
Member

@garbear garbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for including test cases.

Copy link
Contributor

@howie-f howie-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants