[CEncoderFFmpeg] Fix cleanup of buffer managed by AVIOContext #23185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the documentation regarding the buffer passed to avio_alloc_context(): Memory block for input/output operations via AVIOContext. The buffer must be allocated with av_malloc() and friends. It may be freed and replaced with a new buffer by libavformat. AVIOContext.buffer holds the buffer currently in use, which must be later freed with av_free().
lrusak
approved these changes
Apr 22, 2023
| @@ -60,14 +60,17 @@ bool CEncoderFFmpeg::Init() | |||
| if (!m_formatCtx) | |||
| throw FFMpegException("Could not allocate output format context"); | |||
|
|
|||
| m_bcBuffer = static_cast<uint8_t*>(av_malloc(BUFFER_SIZE + AV_INPUT_BUFFER_PADDING_SIZE)); | |||
| if (!m_bcBuffer) | |||
| auto buffer = static_cast<uint8_t*>(av_malloc(BUFFER_SIZE + AV_INPUT_BUFFER_PADDING_SIZE)); | |||
There was a problem hiding this comment.
The documentation doesn't say that the buffer should be in any particular state so I think a regular av_malloc should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From the documentation regarding the buffer passed to avio_alloc_context():
Memory block for input/output operations via AVIOContext. The buffer must be allocated with av_malloc() and friends. It may be freed and replaced with a new buffer by libavformat. AVIOContext.buffer holds the buffer currently in use, which must be later freed with av_free().
Motivation and context
Manage memory as described in the documentation.
How has this been tested?
Hasn't been tested!
What is the effect on users?
Unknown, maybe could have caused crashes in the past.
Types of change
Checklist: