[PVR] Prevent crash on saved search

[emveepee]

Description

When a PVR search is first created it is possible to hit Save which saves to the database and then performs a search. In this scenario the searchFilter parameter is not instantiated before OpenDialogSearch() is called leading to crash when it is referenced.

Check that the searchFilter is not empty before trying to populate it.

Motivation and context

This fixes a hard crash.

How has this been tested?

I could not determine the merit of the code that is causing the crash, but I assume it would handle a future change in the database persistance logic if the row id were to change. In the case of a new search this would not be an in issue.

Also for new searches the passed searchField parameter is also a class variable and the class variable is initialized in SetSearchFilter().

Tested on Windows 11 with current Omega build.

What is the effect on users?

The search is saved but it avoids a crash. It might be possible to remove save as an option on the first call but for users who repeat known searches on clients this would introduce an extra strep.

Screenshots (if appropriate):

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• None of the above (please explain below)

Checklist:

• My code follows the Code Guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the Contributing document
• I have added tests to cover my change
• All new and existing tests passed

[ksooo]

Good catch. Thanks. Could you open a backport PR, please?

[ksooo]

jenkins build this please