Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nexus][PVR] Prevent crash on saved search #23195

Merged
merged 1 commit into from Apr 23, 2023
Merged

Conversation

emveepee
Copy link
Contributor

Description

Backport of PR# 21933

Motivation and context

How has this been tested?

What is the effect on users?

Fixes crash on search.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@emveepee emveepee requested a review from ksooo as a code owner April 23, 2023 17:57
@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Component: PVR Type: Backport v20 Nexus labels Apr 23, 2023
@ksooo ksooo added this to the Nexus 20.2 milestone Apr 23, 2023
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@ksooo
Copy link
Member

ksooo commented Apr 23, 2023

Jenkins errors are unrelated.

00:20:52.047   SubtitleParserWebVTT.cpp
00:20:52.550 c1xx : error C3859: Failed to create virtual memory for PCH [C:\jenkins-workspace\workspace\WIN-64\kodi-build.x64\libkodi.vcxproj]
00:20:52.550 c1xx : message : the system returned code 1455: The paging file is too small for this operation to complete. [C:\jenkins-workspace\workspace\WIN-64\kodi-build.x64\libkodi.vcxproj]
00:20:52.550 c1xx : message : please visit https://aka.ms/pch-help for more details [C:\jenkins-workspace\workspace\WIN-64\kodi-build.x64\libkodi.vcxproj]
00:20:52.550 c1xx : fatal  error C1076: compiler limit: internal heap limit reached [C:\jenkins-workspace\workspace\WIN-64\kodi-build.x64\libkodi.vcxproj]

@ksooo ksooo merged commit 00398d5 into xbmc:Nexus Apr 23, 2023
1 of 2 checks passed
@emveepee emveepee deleted the searchbackport branch June 7, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Type: Backport Type: Fix non-breaking change which fixes an issue v20 Nexus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants