Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Estuary] MyPVRTimers: Fix visibility of 'next recording' label. #23202

Merged

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Apr 25, 2023

"Next recording on" label should only appear in the "Timers" window and not in any dialog put on top of it.

Timers window

screenshot00003

Before: Programme info dialog on top of Timers window

screenshot00002

After: Programme info dialog on top of Timers window

screenshot00004

How to reproduce:

  1. Open Timers window
  2. Open the context menu of any timer
  3. Select "Programme informatiom" context menu item

@jjd-uk can you please review.

@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Component: Skin v21 Omega labels Apr 25, 2023
@ksooo ksooo added this to the Omega 21.0 Alpha 2 milestone Apr 25, 2023
@ksooo ksooo requested a review from jjd-uk April 25, 2023 06:31
Copy link
Member

@jjd-uk jjd-uk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksooo ksooo merged commit 82f2bae into xbmc:master Apr 27, 2023
1 check passed
@ksooo ksooo deleted the estuary-mypvrtimers-fix-nextrecording-label branch April 27, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Skin Type: Fix non-breaking change which fixes an issue v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants