[cmake] addons: windows: only add sse2 flags for x86

[lrusak]

I noticed that the build log for win64 has a lot of lines like this:

20:18:35 [  2%] Building CXX object CMakeFiles/peripheral.joystick.dir/src/addon.cpp.obj
20:18:35 cl : Command line warning D9002 : ignoring unknown option '/arch:SSE2'

This should clear that up

ref: https://stackoverflow.com/questions/1067630/sse2-option-in-visual-c-x64

What is the effect on users?

less spam in the build log?

[thexai]

Fine but commit/PR title seems confusing:

You cannot "remove SSE2 support" from x64 because SSE2 instructions are supported on all x64 processors. Then maybe something like:

"Remove /SSE2 build flag from x64 as SSE2 support is already enabled by default"

or

"remove unnecessary /SSE2 build flag from x64"

[wsnipex]

I guess https://github.com/xbmc/xbmc/blob/master/cmake/modules/FindSSE.cmake#L130-L137 is redundant

[lrusak]

So I think there is some misunderstanding here as this only effects the add-on build IIRC. These scripts only have some variables available.

message("TARGET_ARCHITECTURE: ${TARGET_ARCHITECTURE}")
message("cmakeArch: ${cmakeArch}")
message("Platform: $ENV{Platform}")
message("ARCH: ${ARCH}")
message("CMAKE_GENERATOR_PLATFORM: ${CMAKE_GENERATOR_PLATFORM}")

x64

14:46:08 TARGET_ARCHITECTURE: 
14:46:08 cmakeArch: 
14:46:08 Platform: x64
14:46:08 ARCH: 
14:46:08 CMAKE_GENERATOR_PLATFORM: 

x86

14:49:27 TARGET_ARCHITECTURE: 
14:49:27 cmakeArch: 
14:49:27 Platform: x86
14:49:27 ARCH: 
14:49:27 CMAKE_GENERATOR_PLATFORM: 

[thexai]

The changes are correct and although variable value is x86 in commit name it would be more correct to talk about win32 because x86 is both 32 and 64 bits

[lrusak]

The changes are correct and although variable value is x86 in commit name it would be more correct to talk about win32 because x86 is both 32 and 64 bits

well it seems that windows refers to x86 as 32bit and x64 as 64bit no?

[AlwinEsch]

With more less warnings is always good, thanks about the fix!