Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] extern C for ffmpeg includes #23224

Merged
merged 1 commit into from
May 2, 2023

Conversation

CrystalP
Copy link
Contributor

@CrystalP CrystalP commented May 1, 2023

Description

Changed ffmpeg includes that were not already surrounded with extern "C".

Motivation and context

C functions should be enclosed in extern "C" blocks for correctness, even though linker seems able to work around when missing.

How has this been tested?

Windows 10 x64 and UWP x64. The code linked before and after.
No difference in program behavior before / after light testing

What is the effect on users?

none

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@CrystalP CrystalP requested a review from garbear as a code owner May 1, 2023 18:10
Copy link
Member

@garbear garbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

RP changes look good.

@lrusak lrusak added Type: Improvement non-breaking change which improves existing functionality v21 Omega labels May 2, 2023
@lrusak lrusak added this to the Omega 21.0 Alpha 2 milestone May 2, 2023
@CrystalP CrystalP merged commit acaf1ae into xbmc:master May 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement non-breaking change which improves existing functionality v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants