Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webos: Add buffer info settings #23232

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

sundermann
Copy link
Contributor

@sundermann sundermann commented May 4, 2023

Description

This limits the buffer to a much smaller size than the defaults.

Motivation and context

The default buffer settings are very large (usually more than 10s) leading to a lot of strain on the IO and decoder when starting a video. This change limits the buffer to a more reasonable level so we run into the buffer limit a lot faster. The buffer sizes are taken from other webOS streaming apps and seem like a reasonable default.

How has this been tested?

LG OLED77C28LB (webOS 7/22)

What is the effect on users?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

This limits the buffer to a much smaller size than the defaults.
@wsnipex wsnipex added Type: Improvement non-breaking change which improves existing functionality Component: Video v21 Omega Platform: webOS labels May 4, 2023
@wsnipex wsnipex added this to the Omega 21.0 Alpha 2 milestone May 4, 2023
@wsnipex wsnipex requested a review from lrusak May 8, 2023 08:54
Copy link
Contributor

@lrusak lrusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straightforward

@fuzzard fuzzard merged commit cf42370 into xbmc:master May 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Video Platform: webOS Type: Improvement non-breaking change which improves existing functionality v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants