Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webOS] Screensaver support #23242

Merged
merged 2 commits into from
May 10, 2023
Merged

Conversation

sundermann
Copy link
Contributor

Description

Provides proper screensaver support. Needs update of webos-userland on the mirrors. I have adjusted the BASE_URL temporarily.

Motivation and context

Videos were playing fine before without being interrupted by the screensaver. However, it was only visually disabled. From when the screensaver would normally have kicked in, we would still need an additional button press on the remote to interact with kodi again. This PR adds proper screensaver support using the luna bus.

How has this been tested?

LG OLED77C28LB (webOS 7/22)

What is the effect on users?

Fixes needing to press a button twice after some time

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@sundermann sundermann requested a review from yol as a code owner May 6, 2023 14:08
cmake/modules/FindWebOSHelpers.cmake Outdated Show resolved Hide resolved
tools/depends/target/webos-userland/Makefile Outdated Show resolved Hide resolved
xbmc/windowing/wayland/OSScreenSaverWebOS.cpp Outdated Show resolved Hide resolved
@wsnipex wsnipex added Type: Improvement non-breaking change which improves existing functionality v21 Omega Platform: webOS labels May 7, 2023
@wsnipex wsnipex added this to the Omega 21.0 Alpha 2 milestone May 7, 2023
@sundermann
Copy link
Contributor Author

Squashed the fixups

@wsnipex wsnipex merged commit 460c891 into xbmc:master May 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: webOS Type: Improvement non-breaking change which improves existing functionality v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants