Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webos: Remove mpeg2, mpeg4 and vc1 support #23257

Merged

Conversation

sundermann
Copy link
Contributor

Description

It seems those formats are not supported through the bufferstream API we are using.

Motivation and context

As reported in #23251, #23250 and #23249 those formats don't play. Even though those files play fine using the internal media player, we are using a different API in kodi which seems to not support these files. There is some hope for MPEG4 videos to work with our API, however it needs more research. So for now just disable those 3 formats which are usually low res videos anyway which can likely run fine using ffmpeg software decoding

How has this been tested?

OLED77C28LB

What is the effect on users?

Playback of those files using ffmpeg as fallback

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

It seems those formats are not supported through the bufferstream API we are using
@UltraHDR
Copy link

UltraHDR commented May 8, 2023

Thanks a lot for the quick turn around. I tested the built IPK and this is a good enough workaround for non HD files. Thanks

@fuzzard fuzzard merged commit c2308ea into xbmc:master May 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Video Platform: webOS Type: Fix non-breaking change which fixes an issue v21 Omega
Projects
None yet
4 participants