Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools/depends][target] remove meson_cross_setup #23279

Merged
merged 1 commit into from
May 20, 2023

Conversation

fuzzard
Copy link
Contributor

@fuzzard fuzzard commented May 14, 2023

Description

We moved the meson cross file setup to the configure script in 0ef3158. Just remove the remnants

Motivation and context

Just noticed as i had a minute.

How has this been tested?

Jenkins linux/android/apple builds run

What is the effect on users?

N/A

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

We moved the meson cross file setup to the configure script. Just remove the remnants
Copy link
Contributor

@lrusak lrusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok. I'm surprised this wasn't removed in the original PR.

@fuzzard
Copy link
Contributor Author

fuzzard commented May 19, 2023

Oversight and stupidity obviously 😉

@fuzzard fuzzard merged commit d7c8425 into xbmc:master May 20, 2023
2 checks passed
@fuzzard fuzzard deleted the remove_mesoncross branch May 20, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants