Pipewire: Catch exceptions in CPipewire::Create() #23282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neo1973
added
Type: Fix
enen92
reviewed
May 15, 2023
| } | ||
| catch (const std::exception&) | ||
| { | ||
| return false; |
There was a problem hiding this comment.
wouldn't it make sense to log the actual exception?
There was a problem hiding this comment.
I added logging, but unfortunately it doesn't show up in the log because the logger is not yet initialized. But it helps when logging directly to the console 🙂
lrusak
reviewed
May 16, 2023
| return false; | ||
| try | ||
| { | ||
| pipewire = PIPEWIRE::CPipewire::Create(); |
There was a problem hiding this comment.
We already have try/catch blocks in PIPEWIRE::CPipewire::Create It would be nice if we could just catch the exception in there.
There was a problem hiding this comment.
Moved the exception handling to CPipewire::Create.
neo1973
changed the title
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CPlatformLinux::InitStageOne()doesn't expectOPTIONALS::*Register()methods to throw so exceptions aren't handled, they bubble up the stack and crash the application.Motivation and context
An exception from
CAESinkPipewire::Register()crashed Kodi in #23225 which isn't good behaviour even if the host system is setup in an expected way.How has this been tested?
Artificially create an exception in
CAESinkPipewire::Register(). Kodi doesn't crash and instead initializes the pulseaudio interface.What is the effect on users?
Kodi doesn't crash maybe there even is sound.
Types of change
Checklist: