Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android_main: move the native method register to the owner classes #23309

Merged
merged 2 commits into from
May 24, 2023

Conversation

joseluismarti
Copy link
Contributor

Description

Move the code of the androin_main class that registers some native JNI methods to the related classes: CJNIMainActivity and CJNIXBMCBroadcastReceiver.

Motivation and context

The aim is to use the same criteria as for the other classes and interfaces, and simplify the android_main code.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@enen92 enen92 added Type: Improvement non-breaking change which improves existing functionality Platform: Android v21 Omega labels May 20, 2023
@enen92 enen92 added this to the Omega 21.0 Alpha 2 milestone May 20, 2023
@fuzzard fuzzard merged commit 8493aa7 into xbmc:master May 24, 2023
2 checks passed
@joseluismarti joseluismarti deleted the RegisterNatives branch May 24, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: Android Type: Improvement non-breaking change which improves existing functionality v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants