Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macos] allow primary executable target to be built as bundle #23321

Merged
merged 1 commit into from
May 27, 2023

Conversation

fuzzard
Copy link
Contributor

@fuzzard fuzzard commented May 23, 2023

Description

Instead of building the kodi target as a binary, build as a bundle. This fixes not being able to use keyboard input when running kodi target in xcode for debugging.

Motivation and context

Inability for keyboard to work when running kodi via xcode.

How has this been tested?

Build via xcode/unix makefiles, generated dmg and executing
Build Kodi target in xcode project, and keyboard input works.

What is the effect on users?

N/A

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@fuzzard fuzzard added Type: Fix non-breaking change which fixes an issue Platform: macOS v21 Omega labels May 23, 2023
@fuzzard fuzzard added this to the Omega 21.0 Alpha 2 milestone May 23, 2023
Copy link
Member

@enen92 enen92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runtime tested. Thanks much

Instead of building the kodi target as a binary, build as a bundle.
This fixes not being able to use keyboard input when running kodi target in xcode
for debugging.
@fuzzard fuzzard merged commit b2b06f1 into xbmc:master May 27, 2023
2 checks passed
@fuzzard fuzzard deleted the macos_bundlekoditarget branch May 27, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: macOS Type: Fix non-breaking change which fixes an issue v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants