Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Add render method information to the debug OSD #23377

Merged
merged 1 commit into from Jun 16, 2023
Merged

[Windows] Add render method information to the debug OSD #23377

merged 1 commit into from Jun 16, 2023

Conversation

CrystalP
Copy link
Contributor

Description

Added line to the debug OSD for Windows render method information.

For now, name and optional render method provided string.
With PR#23359 the intermediate target format will be added.

The DXVA render method returns the status of the Video Super Resolution feature.

Motivation and context

The render method changes depending on dxva support for input/output conversions and it's convenient to have the information on screen rather than in debug log only.
Same for the new dxva super video resolution scalers activation status.

How has this been tested?

Windows and auto/dxva/pixel shaders/software renderer render method settings, including situations with fallback from dxva to ps.

Unable to test super resolution, no suitable hardware on hand.

What is the effect on users?

Helpful for devs.

Screenshots (if appropriate):

image

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@CrystalP CrystalP added this to the Omega 21.0 Alpha 3 milestone Jun 10, 2023
@thexai
Copy link
Member

thexai commented Jun 10, 2023

Looks good:

osd

thexai
thexai reviewed Jun 10, 2023
View reviewed changes
xbmc/cores/VideoPlayer/VideoRenderers/windows/RendererDXVA.cpp Outdated
if (m_processor && DX::Windowing()->SupportsVideoSuperResolution())
{
return StringUtils::Format("Video Super Resolution: {}",
m_processor->IsVideoSuperResolutionEnabled() ? "enabled" : "OFF");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, now thinking that as final decision on Super Resolution enabled or not is in Nvidia driver and driver settings (Kodi only request enable) and is not possible confirm if is enabled or not (no API available yet) is better change this to:

requested enable

to avoid users confusion

Copy link
Contributor Author

@CrystalP CrystalP Jun 10, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's fine, I didn't use ON for that reason. I think "requested" is enough and better than enabled.

@fuzzard
Copy link
Contributor

fuzzard commented Jun 11, 2023

Jenkins build this please

1 similar comment
@thexai
Copy link
Member

thexai commented Jun 11, 2023

Jenkins build this please

@CrystalP
Copy link
Contributor Author

@KarellenX Wiki update is not possible at this moment (problem with screenshot upload).
Want me to wait for the Wiki to be fixed or could I merge and update the wiki when it's available?

@KarellenX
Copy link
Member

Yes, best to merge. No need to hold this up for the wiki.
Thanks.

@CrystalP CrystalP merged commit 3643f91 into xbmc:master Jun 16, 2023
2 checks passed
@KarellenX
Copy link
Member

I've made a report here... https://github.com/xbmc/infrastructure/issues/48

@CrystalP
Copy link
Contributor Author

Wiki page https://kodi.wiki/view/Player_process_info updated with new screenshot.
I didn't figure out how to change the "Page updated for v20" at the top to v21.

@KarellenX
Copy link
Member

I didn't figure out how to change the "Page updated for v20" at the top to v21.

At the bottom of the wiki page, you will see... {{updated|20}}
Simply change to {{updated|21}}
I've already done it on that page.

@CrystalP CrystalP deleted the rendermethod-debuginfo branch July 1, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thexai thexai thexai approved these changes

Assignees
No one assigned
Labels
Component: Video rendering Platform: Windows Platform: WindowsStore Type: Improvement non-breaking change which improves existing functionality v21 Omega Wiki: Done
Projects
None yet
Milestone
Omega 21.0 Alpha 2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CrystalP @thexai @fuzzard @KarellenX