[Android][cmake] adjust macros according to the API we are targeting

[joseluismarti]

Description

As we're targeting API level 21:

Requires the _LARGEFILE_SOURCE macro to be used to make fseeko and ftello available. It would not be necessary from API level 24 onwards.

Does not require the _LARGEFILE64_SOURCE macro to be used to make off64_t and corresponding functions available. These functions are available in the NDK at the current API level.

Also does not require the _FILE_OFFSET_BITS=64, these counterpart functions have been progressively incorporated into the NDK.

The __USE_FILE_OFFSET64 macro is the internal flag that should never be set by user code.

How has this been tested?

I've tested it on Fire TV (32 bits) and it works as usual, it plays files larger than 2GiB correctly.

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• None of the above (please explain below)

Checklist:

• My code follows the Code Guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the Contributing document
• I have added tests to cover my change
• All new and existing tests passed

[jenkins4kodi]

I've made some formatting changes to meet the current code style. The diffs are available in the following links:

• PR23414-0002-5a372da541-Remove-typedef-redefinition.diff
• PR23414.diff

For more information please see our current code style guidelines.

[fritsch]

Seems some the enforcing of the offset being 64 bit is still needed. This causes regressions. As on 32 bit userspace not enough bits.

[joseluismarti]

I've tried reverting the commit locally and there is no difference in seeking performance when playing a video via SMB. Tested on Android armv7.

I don't think this is the cause, we will have to do more tests or wait for more feedback.

[neo1973]

@joseluismarti: Could you upload your local build somewhere so @MishaIsay could try it on their setup? Just to make sure this isn't the issue.

[joseluismarti]

A test apk with the revert of this commit in case anyone needs to do some testing.

As the signature is different you must uninstall Kodi first. If necessary make a backup since uninstalling deletes everything.

Edited: I've checked it again and causes a regression when seeking.

[MishaIsay]

Seeking in that build works correctly.