New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build jsonschemabuilder for all platforms from source #23419
Conversation
copy CMakeLists.txt and readme/license to src folder Update CMakeLists.txt to be located in src folder. Add c++17 standard
…S macro In the event we dont have/need a VERSION file to exist, we can skip the use of it
Update FindJsonSchemaBuilder.cmake to build in tree for all platforms. JsonSchemaBuilder doesnt have versioning, but its a single file build, so just build always unless WITH_JSONSCHEMABUILDER is provided
5ef4167
to
0a8e90d
Compare
This will probably work on Linux since we don't ship it. |
Please when I run buildsetup win x64 I receive this message error Have one tip how I solve, please -- Configuring incomplete, errors occurred! |
@MediaBrasil
|
All new by zero, same error, and I noticed one error before cmake, but it's installed and worked before " CMake Error at CMakeLists.txt:2 (project): -- The CXX compiler identification is unknown -- Configuring incomplete, errors occurred! |
here a few more about it -- Build files have been written to: G:/xbmcomeganew/kodi-build.x64
CUSTOMBUILD : CMake warning : [G:\xbmcomeganew\kodi-build.x64\JsonSchemaBuilder.vcxproj]
-- Selecting Windows SDK version 10.0.22621.0 to target Windows 10.0.25393. |
None of those errors have anything to do with this change. The error is it can't find a correct compiler. Use a developer command prompt or set appropriate env cars for target |
Thanks for explain, have one simple way to fix it, I never set env cars before, Uninstall and install cmake work? |
Make sure you have vswhere.exe in this path:
if not you may fix editing location here: xbmc/tools/buildsteps/windows/vswhere.bat Line 38 in 70a7839
Maybe you have Visual Studio installed in custom location, etc. |
Thanks, checked and all is correct, default place. and vswhere.exe is in the correct place. Appreciate your time and info about it |
All is fine now, I remove visual studio and reinstall all, solving the issue. |
Description
Build jsonschemabuilder from source for all platforms
Motivation and context
Less prebuilt windows dependencies. Its a one source file program, so building in tree always is a minimal time add.
How has this been tested?
Jenkins
What is the effect on users?
N/A
Screenshots (if appropriate):
Types of change
Checklist: