Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Add "Graphics" log component for Direct3D #23422

Merged
merged 1 commit into from
Jun 22, 2023
Merged

[Windows] Add "Graphics" log component for Direct3D #23422

merged 1 commit into from
Jun 22, 2023

Conversation

CrystalP
Copy link
Contributor

@CrystalP CrystalP commented Jun 20, 2023 •
edited
Loading

Description

Moved the output of a few D3D11 enumeration functions into the VIDEO component to lighten the typical debug log.

Motivation and context

Clean up the debug log for the most common situations.
It was brought up that the Windows log is getting too busy.

How has this been tested?

Ran with/without the component enabled,

What is the effect on users?

Easier to read debug log for common problems.

Screenshots (if appropriate):

component enabled:

2023-06-19 20:46:28.350 T:23292   debug <general>: CWinRenderer::SelectRenderer: selected render method: DXVA
2023-06-19 20:46:28.350 T:23292   debug <general>: DXVA::CEnumeratorHD::Open: initializing video enumerator with params: 1920x1080.
2023-06-19 20:46:28.351 T:23292   debug <general>: DXVA::CEnumeratorHD::ProbeProcessorCaps: Supported input formats:
                                                   R16G16B16A16_FLOAT
                                                   R10G10B10A2_UNORM
                                                   R8G8B8A8_TYPELESS
                                                   R8G8B8A8_UNORM
                                                   R8G8B8A8_UNORM_SRGB

... more lines of enumeration ...

2023-06-19 20:46:28.352 T:23292   debug <general>: DXVA::CEnumeratorHD::ProbeProcessorCaps: video processor has 1 rate conversion.
2023-06-19 20:46:28.352 T:23292   debug <general>: DXVA::CEnumeratorHD::ProbeProcessorCaps: video processor has 0x8e6 feature caps.

component disabled:

2023-06-19 20:47:22.225 T:23292   debug <general>: CWinRenderer::SelectRenderer: selected render method: DXVA
2023-06-19 20:47:22.226 T:23292   debug <general>: DXVA::CEnumeratorHD::Open: initializing video enumerator with params: 1920x1080.
2023-06-19 20:47:22.226 T:23292   debug <general>: DXVA::CEnumeratorHD::ProbeProcessorCaps: video processor has 1 rate conversion.
2023-06-19 20:47:22.226 T:23292   debug <general>: DXVA::CEnumeratorHD::ProbeProcessorCaps: video processor has 0x8e6 feature caps.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

There is most likely a Wiki page with the list of components to update,

@CrystalP CrystalP added this to the Omega 21.0 Alpha 3 milestone Jun 20, 2023
@CrystalP CrystalP requested a review from thexai June 20, 2023 00:58
thexai
thexai reviewed Jun 20, 2023
View reviewed changes
addons/resource.language.en_gb/resources/strings.po Outdated
@@ -23453,3 +23453,9 @@ msgstr ""
msgctxt "#39194"
msgid "Enables advanced DXVA upscaler using NVIDIA \"RTX Video Super Resolution\" or \"Intel Video Super Resolution\".[CR]Used when video source is 1080p or less (progressive only) and source resolution is lower than display resolution.[CR]It's only available on specific hardware: NVIDIA RTX 40x, RTX 30x and Intel Arc A770, A750."
msgstr ""

#. Label for debug log component level Graphics - Direct3D, OpenGL or other platform low level API
Copy link
Member

@thexai thexai Jun 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move to line 3161, currently:

#empty string with id 673

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe they need to remain empty on purpose? Moot point anyway with reuse of VIDEO.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe they need to remain empty on purpose

No, empty "slots" are for use and able to group similar things in logical order (not all new entries at end). Although sometimes there is no choice but to add the new things at the end.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a new category is created it can be moved here, otherwise N/A.

thexai
thexai reviewed Jun 20, 2023
View reviewed changes
xbmc/commons/ilog.h Outdated
@@ -45,3 +45,4 @@ constexpr int LOGEPG = (1 << (LOGMASKBIT + 16));
constexpr int LOGANNOUNCE = (1 << (LOGMASKBIT + 17));
constexpr int LOGWSDISCOVERY = (1 << (LOGMASKBIT + 18));
constexpr int LOGADDONS = (1 << (LOGMASKBIT + 19));
constexpr int LOGGRAPHICS = (1 << (LOGMASKBIT + 20));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I not think new category is necessary. LOGVIDEO already exist for these things and is almost not used in Windows.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwik LOGVIDEO is used by VP, for me it is no problem to reuse the existing one,
maybe a third evaluation by someone else would be nice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used every frame by vp but for addons only it seems. For internal it barely logs anything when playing (I tried). Reusing will work with things as they are now.

@CrystalP
Copy link
Contributor Author

No new component => removed the need to update documentation or wiki.
@CastagnaIT good with the solution?

@CastagnaIT
Copy link
Collaborator

CastagnaIT commented Jun 22, 2023 •
edited
Loading

yeah tested better now thanks

@CrystalP CrystalP merged commit 869a6fc into xbmc:master Jun 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CastagnaIT CastagnaIT CastagnaIT approved these changes

@thexai thexai thexai approved these changes

@KarellenX KarellenX Awaiting requested review from KarellenX

Assignees
No one assigned
Labels
Component: Logging Component: Settings Platform: Windows Platform: WindowsStore Type: Improvement non-breaking change which improves existing functionality v21 Omega
Projects
None yet
Milestone
Omega 21.0 Alpha 3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CrystalP @CastagnaIT @thexai