Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windowing: fix dialog confirmation not showing when moving fullscreen… #23432

Merged
merged 1 commit into from Jun 23, 2023

Conversation

enen92
Copy link
Member

@enen92 enen92 commented Jun 23, 2023

… window

Description

This fixes a small regression introduced in 15f6e65 (#23335) where the dialog confirmation was not shown when selecting a different monitor in display settings (and running fullscreen).

@CrystalP since this was reported by you it'd be nice if you can confirm the fix/runtime test on windows. Sorry for the small amount of time this took (not easy with a baby screaming every two hours :) )

Motivation and context

Keep previous behaviour.

How has this been tested?

Runtime tested on macos (nativewindowing)

What is the effect on users?

Dialog is shown when moving the window from settings between screens

Screenshots (if appropriate):

image

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@enen92 enen92 added Type: Fix non-breaking change which fixes an issue Component: Windowing v21 Omega labels Jun 23, 2023
@enen92 enen92 added this to the Omega 21.0 Alpha 3 milestone Jun 23, 2023
@enen92 enen92 requested a review from CrystalP June 23, 2023 12:14
@CrystalP
Copy link
Contributor

There was no rush, thank you.

There was a pre-existing issue that I meant to take a look at with the yes/no dialog (at least in Windows): it pops up with neither buttons focused and navigation with keyboard or remote to select yes or no doesn't work. Only the mouse will work. Wondering if you saw something similar on mac / linux?

Copy link
Contributor

@CrystalP CrystalP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runtime tested, works fine.

@enen92 enen92 merged commit 8c7d2e7 into xbmc:master Jun 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Windowing Type: Fix non-breaking change which fixes an issue v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants