Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Remove unnecessary if and use MediaFormat constants #23442

Merged

Conversation

joseluismarti
Copy link
Contributor

Description

Remove unnecessary if used previously for logging.

Also replace in this method the constants used directly by value by the corresponding MediaFormat constant names.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@thexai thexai added Type: Improvement non-breaking change which improves existing functionality Platform: Android Component: Audio v21 Omega labels Jun 25, 2023
@thexai thexai added this to the Omega 21.0 Alpha 3 milestone Jun 25, 2023
@fuzzard
Copy link
Contributor

fuzzard commented Jun 25, 2023

Jenkins build this please

1 similar comment
@joseluismarti
Copy link
Contributor Author

Jenkins build this please

@fuzzard fuzzard merged commit faf27af into xbmc:master Jun 26, 2023
2 checks passed
@joseluismarti joseluismarti deleted the CDVDAudioCodecAndroidMediaCodec-if branch June 26, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Audio Platform: Android Type: Improvement non-breaking change which improves existing functionality v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants