Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] remove unused extra frame rate doubling for interlaced resolutions in CVideoSyncD3D #23463

Merged
merged 2 commits into from Jul 2, 2023

Conversation

CrystalP
Copy link
Contributor

@CrystalP CrystalP commented Jul 1, 2023

Description

The Interlaced() function always returns false anyway due to initialization of m_interlaced to false and no code to change the value. It is not an overriden virtual function and looks like a left over from old code.
For interlaced resolutions, DeviceResources::GetDisplayMode() provides frame rate doubling.

The Xbox code doesn't have frame rate doubling but the hdmi information doesn't signal interlaced resolutions. The Xbox likely doesn't support interlaced resolutions.
@thexai could you confirm?

Motivation and context

Cleanup leftovers of old code.

How has this been tested?

Don't have a screen that reports interlaced resolutions anymore. No change for progressive resolutions on Windows 10.

What is the effect on users?

None.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@CrystalP CrystalP added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Component: Video Platform: Windows Platform: WindowsStore v21 Omega labels Jul 1, 2023
@CrystalP CrystalP added this to the Omega 21.0 Alpha 3 milestone Jul 1, 2023
@CrystalP CrystalP requested a review from thexai July 1, 2023 23:56
Copy link
Member

@thexai thexai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Xbox (at least current models) not supports interlaced display modes and if any old model supports it is not handled anyway in current code.

@CrystalP CrystalP merged commit 4dcaf86 into xbmc:master Jul 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Video Platform: Windows Platform: WindowsStore Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants