[Estuary] Reset timer as long as the osd is shown

[enen92]

Description

This fixes another misbehaviour that I've found while using the topbar overlay of estuary. The timer is started on window load however this dialog is completely tied to the OSD dialog. It is shown when doing seeks, pause, etc but is also shown whenever the OSD is displayed with stuff like muted, the clearart, the title, etc. This means that the timer might elapse as long as the OSD is visible for a couple of seconds. If you pause the video in the video OSD (using the controls) and close the dialog the topbar overlay will be shown forever.

Motivation and context

Some day we'll have 0 bugs... :)

How has this been tested?

Same as before, pausing, rewinding, seeking, etc. Checking the dialog is shown and closed after the elapsed time

What is the effect on users?

Fixes the regression with the topbaroverlay being displayed after a pause in the video OSD.

Screenshots (if appropriate):

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• None of the above (please explain below)

[enen92]

Merging myself since this is a simple change on the timer definition (skin/estuary only). I'll track possible regressions as usual.

[CrystalP]

I tried to runtime test but did not understand the problem well enough (the "whenever the OSD is displayed with stuff like muted, the clearart, the title, etc." part) and didn't see anything wrong in master.
Could you give a more detailed example?

[enen92]

@CrystalP sure thing, here you can find a video screencast of the bug:

https://youtu.be/ombVQ5n14xM

And here the behaviour on current master now:

https://youtu.be/2CSTfsOEj94

Found while using my tv remote to control kodi, I usually forget there's a bultin button for pause and I just pause it from the OSD :)

[CrystalP]

Found a combination that triggers it and no remote needed. play > enter (OSD appears when pause button highlighted) > enter (play pauses) > escape (OSD disappears, the top bar remains)

And it's cured by the PR. Good job!

[enen92]

That's exactly the issue this PR fixes (and illustrated in the videos of the last comment) :)